pass in transcript message to send_speech_to_output #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m5a0r7
pushed a commit
to m5a0r7/vocode-python
that referenced
this pull request
Oct 19, 2023
* pass in transcript message to send_speech_to_output * publish to events manager * remove commented code * move transcript add to later in send_speech_to_output * one more fix * adds note on azure synthesizer * adds comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the transcript as the bot message is being spoken - now, we don't have to update the transcript on cut-off, it will already reflect what has been said so far.
old world implementation:
this is failing spectacularly for cases when the agent sends multiple messages in a row to the
AgentResponseWorker, since we were updating the wrong "last bot message" in the transcriptnew world implementation:
send_speech_to_output(in theSynthesisResultsWorker)send_speech_to_outputis finished